[WPB-8712] use treefmt for everything #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
|
I think I want to readd some |
MangoIV
changed the title
MangoIV
requested review from
akshaymankar
and removed request for
akshaymankar
|
there's one tradeoff to adding hlint to this is that it will make the initial lint very slow (will take ~5 minutes) but after then the cache kicks in and only changed files are re-linted. |
fisx
approved these changes
Apr 17, 2024
| make hlint-inplace-pr | ||
| make hlint-check-pr # sometimes inplace has been observed not to do its job very well. | ||
| make format |
There was a problem hiding this comment.
Suggested change
| make format | |
| make format | |
| make formatc # (at some point in the past, this has caught ormolu screwing up with inplace) |
this might be fixed now with the --check-inplace argument, but can we be certain?
but if you prefer, we can remove this and see if it happens again.
There was a problem hiding this comment.
--check-idempotence? i have removed formatc, i think...
There was a problem hiding this comment.
i was hoping that ormolu by now is idempotent or at least the idempotency check works reliably 👀
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
pcapriotti
pushed a commit
that referenced
this pull request
Apr 23, 2024
1 task
MangoIV
added a commit
that referenced
this pull request
Apr 29, 2024
fisx
pushed a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-8712
Checklist
changelog.d