[WPB-7222] Drop depencency on convertible-strings in production code

[mdimjasevic]

The PR removes all usages of the cs function (from ConvertibleStrings) in the application code.

Tracked by https://wearezeta.atlassian.net/browse/WPB-7222.

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[MangoIV]

this is a tricky PR; a lot of trivial changes but some changes that you have to look at carefully 👀

[fisx]

i would really appreciate if you could drop the habit of reformatting so much to your taste, specifically line add line breaks. if we all keep doing that we'll drown in diff noise.

it's probably hard for you because it's done by your tooling? but maybe you can turn it off somehow, or at least dial it down?

just for the future. otherwise this is all fine 👍

[MangoIV]

i would really appreciate if you could drop the habit of reformatting so much to your taste, specifically line add line breaks. if we all keep doing that we'll drown in diff noise.

@fisx this wasn't me this time! Marko did all these formatting changes; I actually like them though, it makes the lines a tad shorter. :D

[MangoIV]

Argh. Hoogle upload is stuck again

[mdimjasevic]

i would really appreciate if you could drop the habit of reformatting so much to your taste, specifically line add line breaks. if we all keep doing that we'll drown in diff noise.

I did this line reformatting and I disagree with what you just said: to me this is not diff noise. I either have to use a tiny tiny font size to see the whole 120+ character line I am editing (which is bad for my health) or I have to break it up into smaller chunks so I can see in one screen what I am editing.

Also, you can configure the GitHub web UI to ignore white space diff when reviewing, which will highlight the actual changes.

Let me know if you know of a way how to edit this in a manageable way and without breaking up the long lines.

[MangoIV]

@mdimjasevic i think this was more or less directly to me because I have the habit of doing more or less noisy refactoring on the side and we talked about that and I agreed that it’s bad. So I guess that’s why Matthias reminded me to do that less.

[fisx]

I either...

there is a third choice: set up your editor to support line break. :)

but i get your point. everything anybody does breaks somebody's workflow... https://xkcd.com/1172/

(ignore-whitespace on github doesn't work very well. i suspect it breaks semantics sometimes, but worse, it doesn't catch all the noise that bothers me.)

but i've made my point, and i don't see an easy solution. feel free to ignore me, then.

[MangoIV]

out of all things, ormolu decided to not enforce line length but doesn't adhere to one-line formatting anywhere...

[mdimjasevic]

there is a third choice: set up your editor to support line break. :)

Do you mean line wrapping?

but i get your point. everything anybody does breaks somebody's workflow... https://xkcd.com/1172/

Fair, it does break my workflow, but I think it's not just mine. We often pair and we screen-share where we always have to increase the font size so the other side can read from their screen, and for these things long lines are just no good.

[fisx]

sorry, yes, line wrapping.

i'll shut up now. :)