[WPB-5360] update the nginz nginx module to support nginx 1.26 #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out it was not that hard after all, I could trace back our compile issue to a refactoring done in this commit nginx/nginx@3aef1d6?diff=split&w=1 and that was quite easy to fix
MangoIV
commented
May 7, 2024
Comment on lines
+79
to
+82
| version = "1.26.0"; | ||
| src = super.fetchurl { | ||
| url = "https://nginx.org/download/nginx-${version}.tar.gz"; | ||
| hash = "sha256-nrszOp6CuVKs0+K0rrHU/2QG9ySRurbNn+afDepzfzE="; | ||
| hash = "sha256-0ubIQ51sbbUBXY6qskcKtSrvhae/NjGCh5l34IQ3BJc="; |
There was a problem hiding this comment.
this override can also go in the next nixpkgs update. yay.
zebot
added
the
ok-to-test
pcapriotti
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-5360
turns out it was not that hard after all, I could trace back our compile issue to a refactoring done in this commit
nginx/nginx@3aef1d6?diff=split&w=1 and that was quite easy to fix
Checklist
changelog.d