Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names of metrics so they do not contain any dots #4134

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jul 9, 2024

https://wearezeta.atlassian.net/browse/WPB-10093

Fixup for #4085

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 9, 2024
@akshaymankar akshaymankar merged commit 153047d into develop Jul 9, 2024
8 of 10 checks passed
@akshaymankar akshaymankar deleted the fix-metric-names branch July 9, 2024 15:10
@akshaymankar
Copy link
Member Author

Merged without overall-ci because hoogle pipeline was stuck but integration tests were green.

@echoes-hq echoes-hq bot added the echoes: throughput Changes intended at preserving our ability to evolve the software safely and effectively label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: throughput Changes intended at preserving our ability to evolve the software safely and effectively ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants