Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-10308] Use RabbitMQ queues for notifications #4272

Draft
wants to merge 38 commits into
base: develop
Choose a base branch
from
Draft

[WPB-10308] Use RabbitMQ queues for notifications #4272

wants to merge 38 commits into from

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Sep 26, 2024 •
edited by fisx
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines
  • find error, undefined, TODO, and fix them
  • brig currently loads a conn into Env and keeps it even after it dies. we should load an MVar into the env and replace broken chans in a top-level loop (like the old delete users queue in brig).

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Sep 26, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 26, 2024
@battermann battermann changed the title WPB-10308 Use RabbitMQ queues for notifications [WPB-10308] Use RabbitMQ queues for notifications Sep 26, 2024
akshaymankar
akshaymankar reviewed Sep 26, 2024
View reviewed changes
libs/wire-api/src/Wire/API/Error/Brig.hs Outdated
Comment on lines 305 to 306

type instance MapError 'NotificationQueueConnectionError = 'StaticError 500 "notification-queue-connection-error" "Error connecting to the notification queue"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think best not to show these errors to clients. Maybe let's just use InternalServerError.

@akshaymankar akshaymankar force-pushed the WPB-10308-use-rabbti-mq-classic-queues-for-notifications branch 2 times, most recently from 2f580cb to 842158f Compare October 2, 2024 06:32
battermann and others added 21 commits October 2, 2024 08:34
@battermann @akshaymankar
create rabbitmq exchange
ca742c5
@battermann @akshaymankar
set up DLX
dbebff3
@battermann @akshaymankar
wip
ed81a4d
@battermann @akshaymankar
create user queues on client add/update
284161b
@battermann @akshaymankar
make it internal server error
15d8553
@battermann @akshaymankar
make galley compile
a38d8dd
@battermann @akshaymankar
make rabbitmq mandatory
7f6d959
@battermann @akshaymankar
fix integration tests
2521d6a
@battermann @akshaymankar
set correct DLX headers
734969f
@battermann @akshaymankar
wip
57306db
@akshaymankar
Add a WIP test to consume notifs via GET /events
f498812
@akshaymankar
cannon: Roughly implement subscribing notifs from RabbitMQ
70a75f3
@akshaymankar
gundeck: Start implementing push to rabbitmq
0616817
@akshaymankar
integration: Fix assertion to assert on a real event
0ffa1c9
@akshaymankar
integration: Use correct vHost in cannon
52e3948
@akshaymankar
cannon: Ensure exchange exists and publish event correctly on WS
bee8241
@akshaymankar
NotificationSubsystem: Align names for queues and extract them as top…
a0bbbd4 
… level bindings
@akshaymankar
gundeck: Push events to RabbitMQ for compatible clients
f582ba3
@akshaymankar
integration: Assert that acked events don't come back
cc79540
@akshaymankar
cannon: Forward client acks to rabbitmq
e3c9244
@akshaymankar
WIP: Get rid of channel as an explicit param for NotificationSubsyste…
2974f24 
…m actions
@akshaymankar akshaymankar force-pushed the WPB-10308-use-rabbti-mq-classic-queues-for-notifications branch from 842158f to 2974f24 Compare October 2, 2024 06:50
fisx and others added 15 commits October 2, 2024 09:33
@fisx
Use these library better.
727e65f
@fisx
resolve rebase conflict better.
c59b620
@fisx
fix ghc errors.
f745845
@fisx
Extract rabbitmq channel lookup into helper.
5d1b4f4
@fisx
Move setupConsumableNotificationsClient from subsystems to gundeck.
3a1660f
@akshaymankar
Revert "Get galley to compile."
e8a9821 
This reverts commit 8a1840d.
@akshaymankar
wire-subsystems: Fix compile errors in tests
f8b9b8a
@akshaymankar
gundeck: doesn't depend on wire-subsystems (yet?)
a20ad90
@akshaymankar
brig: Remove unnecessary import
f1fbf38
@akshaymankar
cannon: Don't create the queue for clients, expect it to already be t…
c38e974 
…here
@akshaymankar
cannon: close ws connection when something goes wrong
4cda4ad
@akshaymankar
Funky!
389c1b8
@akshaymankar
Undo funkiness: Create Wire.API.WebSocket with types for comms on the…
f8035ae 
… new websocket
@akshaymankar
WIP: cannon: try to use the new types from wire-api
25b9209 
The case split is not the nicest, perhaps we can solve it with one these things:

- Bring back the funkiness for couple of commits ago
- Use separate types for server to client and client to server messages
@akshaymankar
wire-api: Cabal file
82c6647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@battermann @akshaymankar @zebot @fisx