Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new bugs section for OOP Module #239

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Added new bugs section for OOP Module #239

merged 6 commits into from
Jul 19, 2022

Conversation

kaushikpadmanaban
Copy link
Contributor

Added 'bugs' section for OOP module

  • Added a "kinks to be aware of" section for OOP module to document commonly reported bugs on Slack. This page is stored inside the kinks folder in the REPL inside relevant sub-folder.
  • Added a line of code linking the bug page to the main OOP module page
  • Updated the main kinks README.md to display the new section (also includes the DBNW bugs page, which was missing previously)

This update requires assets in the binary-assets repository, which includes a couple of images. I have create a new PR requesting to add them. PR link here

@sglavoie sglavoie self-requested a review July 19, 2022 01:02
sglavoie
sglavoie approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@sglavoie sglavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Thank you!

@sglavoie sglavoie merged commit 7fc28b6 into world-class:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sglavoie sglavoie sglavoie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushikpadmanaban @sglavoie