[photos][photosui] Xcode 14 Beta 1-4 #15608

chamons · 2022-08-02T22:38:37Z

No description provided.

mandel-macaque · 2022-08-02T22:56:33Z

src/Photos/Enums.cs

@@ -413,4 +418,13 @@ public enum PHAccessLevel : long
 		AddOnly = 1,
 		ReadWrite = 2,
 	}
+
+	[TV (16,0), Mac (13,0), iOS (16,0)]


We are missing the MacCatalyst.

mandel-macaque · 2022-08-02T22:56:51Z

src/photos.cs

@@ -158,6 +158,10 @@ interface PHAsset {
 		[TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
 		[NullAllowed, Export ("adjustmentFormatIdentifier")]
 		string AdjustmentFormatIdentifier { get; }
+
+		[TV (15, 0), Mac (12, 0), iOS (15, 0)]


We are missing MacCatalyst.

mandel-macaque · 2022-08-02T22:57:00Z

src/photos.cs

@@ -269,6 +273,14 @@ interface PHAssetResource
 		[Static]
 		[Export ("assetResourcesForLivePhoto:")]
 		PHAssetResource[] GetAssetResources (PHLivePhoto livePhoto);
+
+		[TV (16, 0), Mac (13, 0), iOS (16, 0)]


mandel-macaque · 2022-08-02T22:57:05Z

src/photos.cs

+		[Export ("pixelWidth")]
+		nint PixelWidth { get; }
+
+		[TV (16, 0), Mac (13, 0), iOS (16, 0)]


mandel-macaque · 2022-08-02T22:57:13Z

src/photos.cs

@@ -584,6 +596,9 @@ interface PHAssetCollection {
 		[Export ("fetchAssetCollectionsContainingAsset:withType:options:")]
 		PHFetchResult FetchAssetCollections (PHAsset asset, PHAssetCollectionType type, [NullAllowed] PHFetchOptions options);

+		[Deprecated (PlatformName.iOS, 16, 0, message: "Will be removed in a future release.")]
+		[Deprecated (PlatformName.TvOS, 16, 0, message: "Will be removed in a future release.")]
+		[Deprecated (PlatformName.MacOSX, 13, 0, message: "Will be removed in a future release.")]


Same, Catalyst.

mandel-macaque · 2022-08-02T22:58:46Z

src/photosui.cs

+#if NET // Can't apply Deprecated and Obsoleted to same element
 	[Deprecated (PlatformName.iOS, 13, 0)]
+#endif
+	[Obsoleted (PlatformName.iOS, 14, 0)] // Removed from headers completely


I though we converted the Obsoleted to Deprecated in the generator, don't we?

We do, and then you get 2 copies of the attribute, one which over writes the second (whoever comes last). I have a test explicitly to detect this.

mandel-macaque · 2022-08-02T22:58:58Z

src/photosui.cs

@@ -524,9 +530,17 @@ interface PHPickerViewController
 		[Export ("initWithConfiguration:")]
 		[DesignatedInitializer]
 		NativeHandle Constructor (PHPickerConfiguration configuration);
+
+		[NoWatch, NoTV, Mac (13,0), iOS (16,0)]


mandel-macaque · 2022-08-02T22:59:03Z

src/photosui.cs

+		[Export ("deselectAssetsWithIdentifiers:")]
+		void DeselectAssets (string[] identifiers);
+
+		[NoWatch, NoTV, Mac (13,0), iOS (16,0)]


mandel-macaque · 2022-08-02T22:59:21Z

src/photosui.cs

+
+		[NoWatch, NoTV, Mac (13, 0), iOS (16, 0)]
+		[Static]
+		[Export ("depthEffectPhotosFilter")]
+		PHPickerFilter DepthEffectPhotosFilter { get; }
+
+		[NoWatch, NoTV, Mac (13, 0), iOS (16, 0)]
+		[Static]
+		[Export ("burstsFilter")]
+		PHPickerFilter BurstsFilter { get; }
+
+		[NoWatch, NoTV, Mac (13, 0), iOS (15, 0)]
+		[Static]
+		[Export ("panoramasFilter")]
+		PHPickerFilter PanoramasFilter { get; }
+
+		[NoWatch, NoTV, Mac (13, 0), iOS (15, 0)]
+		[Static]
+		[Export ("screenshotsFilter")]
+		PHPickerFilter ScreenshotsFilter { get; }
+
+		[NoWatch, NoTV, Mac (13, 0), iOS (15, 0)]
+		[Static]
+		[Export ("screenRecordingsFilter")]
+		PHPickerFilter ScreenRecordingsFilter { get; }
+
+		[NoWatch, NoTV, Mac (13, 0), iOS (16, 0)]
+		[Static]
+		[Export ("cinematicVideosFilter")]
+		PHPickerFilter CinematicVideosFilter { get; }
+
+		[NoWatch, NoTV, Mac (13, 0), iOS (15, 0)]
+		[Static]
+		[Export ("slomoVideosFilter")]
+		PHPickerFilter SlomoVideosFilter { get; }
+
+		[NoWatch, NoTV, Mac (13, 0), iOS (15, 0)]
+		[Static]
+		[Export ("timelapseVideosFilter")]
+		PHPickerFilter TimelapseVideosFilter { get; }
+
+		[NoWatch, NoTV, Mac (13,0), iOS (15,0)]
+		[Static]
+		[Export ("playbackStyleFilter:")]


Catalyst is missing.

mandel-macaque · 2022-08-02T22:59:28Z

src/photosui.cs

+		[NoWatch, NoTV, Mac (13,0), iOS (15,0)]
+		[Static]
+		[Export ("allFilterMatchingSubfilters:")]
+		PHPickerFilter GetAllFilterMatchingSubfilters (PHPickerFilter[] subfilters);
+
+		[NoWatch, NoTV, Mac (13,0), iOS (15,0)]
+		[Static]
+		[Export ("notFilterOfSubfilter:")]
+		PHPickerFilter GetNotFilterOfSubfilter (PHPickerFilter subfilter);


dalexsoto

After @mandel-macaque 👍 and Api Diff is green

src/Photos/Enums.cs

Co-authored-by: Alex Soto <alex@alexsoto.me>

src/photos.cs

tj-devel709 · 2022-08-03T20:54:34Z

src/photosui.cs

+
+		[TV (10,0), iOS (9,1), NoMac]
+		[Export ("livePhotoView:extraMinimumTouchDurationForTouch:withStyle:")]
+		double ExtraMinimumTouchDuration (PHLivePhotoView livePhotoView, UITouch touch, PHLivePhotoViewPlaybackStyle playbackStyle);


Maybe verb-ify this one

Suggestions welcome on a verb here. You are providing the extra min touch duration.

ProvideExtraMinimumTouchDuration was the best I could come up with, but that's a large delta and I didn't love that.

I'm not sure I understand why GetExtraMinimumTouchDuration doesn't work?

tj-devel709 · 2022-08-03T20:57:36Z

tests/xtro-sharpie/api-annotations-dotnet/common-PhotosUI.ignore

@@ -0,0 +1,2 @@
+# Removed in Xcode 14 from header
+!unknown-type! PHEditingExtensionContext bound


nit missing newline

tj-devel709 · 2022-08-03T20:57:45Z

tests/xtro-sharpie/common-PhotosUI.ignore

@@ -0,0 +1,2 @@
+# Removed in Xcode 14 from header
+!unknown-type! PHEditingExtensionContext bound


nit missing newline

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

chamons · 2022-08-08T14:31:02Z

Blocked now on #15659

chamons · 2022-08-08T20:44:44Z

🤞 that'll fix the test failures.

…5648) - In the [Xcode 14 Photo PR](xamarin#15608) a test is failing with this: ``` ILLINK : error MT2362: The linker step 'Registrar' failed during processing: One or more errors occurred. (The type 'Photos.PHPersistentObjectChangeDetails' (used as a return type in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). [/Users/donblas/Programming/xamarin-macios/tests/dotnet/MySimpleApp/MacCatalyst/MySimpleApp.csproj] ) (The type 'Photos.PHObjectType' (used as a parameter in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeFetchResult' (used as a return type in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeToken' (used as a parameter in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ``` The details of how we fail are written up in [this issue](xamarin#15643) but since sharpie never outputs versions in the form of x.y.z where .z is zero we only hit this with generated attributes. Because of this fact, we can work around it with a generator change. This commit changes how we "imply" attributes from iOS to Catalyst. As a brief reminder, because of historical bindings we assume anything that has iOS and not a Catalyst really means "treat iOS as if it was also Catalyst". This work is done in `AddImpliedCatalyst` and uses `CloneFromOtherPlatform` to make a copy of an attribute, because there is no easy way to say "I want a copy of this, but with this other platform". `CloneFromOtherPlatform` used to always call the 3 version (Major, Minor, Revision) constructor, even when the attribute being cloned only used Major.Minor. However, this caused us to "zero extend" the version with another zero, which triggers this bug, so stop doing that. Uglier code in the generator, but it works better. Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

src/photos.cs

rolfbjarne · 2022-08-17T17:53:53Z

src/photosui.cs

+
+		[TV (10,0), iOS (9,1), NoMac]
+		[Export ("livePhotoView:extraMinimumTouchDurationForTouch:withStyle:")]
+		double ExtraMinimumTouchDuration (PHLivePhotoView livePhotoView, UITouch touch, PHLivePhotoViewPlaybackStyle playbackStyle);


I'm not sure I understand why GetExtraMinimumTouchDuration doesn't work?

…5659) - In the [Xcode 14 Photo PR](xamarin#15608) a test is failing with this: ``` ILLINK : error MT2362: The linker step 'Registrar' failed during processing: One or more errors occurred. (The type 'Photos.PHPersistentObjectChangeDetails' (used as a return type in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). [/Users/donblas/Programming/xamarin-macios/tests/dotnet/MySimpleApp/MacCatalyst/MySimpleApp.csproj] ) (The type 'Photos.PHObjectType' (used as a parameter in Photos.PHPersistentChange.ChangeDetails) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeFetchResult' (used as a return type in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ) (The type 'Photos.PHPersistentChangeToken' (used as a parameter in Photos.PHPhotoLibrary.FetchPersistentChanges) is not available in MacCatalyst 16.0 (it was introduced in MacCatalyst 16.0.0). Please build with a newer MacCatalyst SDK (usually done by using the most recent version of Xcode). ``` The details of how we fail are written up in [this issue](xamarin#15643) but since sharpie never outputs versions in the form of x.y.z where .z is zero we only hit this with generated attributes. Because of this fact, we can work around it with a generator change. This commit changes how we "imply" attributes from iOS to Catalyst. As a brief reminder, because of historical bindings we assume anything that has iOS and not a Catalyst really means "treat iOS as if it was also Catalyst". This work is done in `AddImpliedCatalyst` and uses `CloneFromOtherPlatform` to make a copy of an attribute, because there is no easy way to say "I want a copy of this, but with this other platform". `CloneFromOtherPlatform` used to always call the 3 version (Major, Minor, Revision) constructor, even when the attribute being cloned only used Major.Minor. However, this caused us to "zero extend" the version with another zero, which triggers this bug, so stop doing that. Uglier code in the generator, but it works better. Co-authored-by: Chris Hamons <chris.hamons@xamarin.com>

vs-mobiletools-engineering-service2 · 2022-09-02T18:12:39Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 40f0de9bf5c8c51fa55b229ee65f5ae91dac7c3e [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T18:14:42Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1173.Monterey'
Hash: 40f0de9bf5c8c51fa55b229ee65f5ae91dac7c3e [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T18:33:06Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection
xammac_tests
monotouch-test

Pipeline on Agent
Hash: 40f0de9bf5c8c51fa55b229ee65f5ae91dac7c3e [PR build]

vs-mobiletools-engineering-service2 · 2022-09-02T20:43:15Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 227 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

chamons · 2022-09-02T21:17:07Z

Last failure is just watch.

chamons added 2 commits August 2, 2022 17:35

[photos][photosui] Xcode 14 Beta 1-4

0b0c8b1

Tweak two method names

ddd6a41

chamons added the notes-mention Deserves a mention in release notes label Aug 2, 2022

chamons requested a review from mandel-macaque August 2, 2022 22:38

chamons requested a review from dalexsoto as a code owner August 2, 2022 22:38

mandel-macaque requested changes Aug 2, 2022

View reviewed changes

mandel-macaque added this to the xcode14 milestone Aug 2, 2022