Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.mlbtv@matrix] 2022.4.19+matrix.1 #3968

Closed
wants to merge 1 commit into from
Closed

[plugin.video.mlbtv@matrix] 2022.4.19+matrix.1 #3968

wants to merge 1 commit into from

Conversation

eracknaphobia
Copy link

Add-on details:

Watch every out-of-market regular season game in the office or on the go. The #1 LIVE
Streaming Sports Service

Description of changes:

        - featured videos, including Big Inning
        - audio-only streams
        - unique game icons
        - probable pitchers
        - doubleheader/TBD start times
        - restored "play all recaps" behavior when selecting date
        - moved more text to language localization file
        - additional AddonIsEnabled detection for inputstream adaptive
        - code cleanup

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

@eracknaphobia
Copy link
Author

ERROR: ./plugin.video.mlbtv/resources/lib/mlb.py is marked as stand-alone executable
I've never seen this error before so I'm not sure how to fix it?

@enen92
Copy link
Member

enen92 commented Apr 21, 2022

@eracknaphobia just remove the executable permission on the file:
git update-index --chmod=-x myfile.py
commit and push

@eracknaphobia
Copy link
Author

@enen92 Ok, thanks for the info! I tried to resubmit but hit the same error everything looks correct from what I can tell. I'll keep digging.

image

@enen92
Copy link
Member

enen92 commented Apr 22, 2022

In this submissing mlb.py is marked as executable:
image

@eracknaphobia
Copy link
Author

I forgot to commit the change before submitting... need more coffee

@eracknaphobia
Copy link
Author

eracknaphobia commented Apr 22, 2022

On another note my changes aren't being sent to the matrix pr, just the kyrpton. Should i just close them both and start over?

@enen92
Copy link
Member

enen92 commented Apr 22, 2022

I am not sure what you're using to submit. If using the kodi-addon-submitter action, removing the (local and remote tag) and tagging it again should force push to both PRs.
If you find it easier to just close and resubmit please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants