Expose Assistant Tool input and output json config #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montagon
approved these changes
Sep 26, 2024
misabelcarde
approved these changes
Sep 26, 2024
javipacheco
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previously, the configuration for serialization of both the input and output of tools was common. This means both were treated with the same settings, potentially leading to inefficiencies or non-optimal behavior.
This PR
This PR differentiates the serialization configuration for the tool's input and output JSON.
E.g. It would allow to set parameters like
explicitNulls = truefor inputs, ensuring that null values are explicitly included, while setting it tofalsefor outputs, to potentially omit unnecessary nulls.