Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress _type error, fix 'OBJECT_ADDITIONAL_PROPERTIES' error, add … #2

Merged
merged 3 commits into from
Dec 8, 2017
Merged

suppress _type error, fix 'OBJECT_ADDITIONAL_PROPERTIES' error, add … #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f368c3f
suppress _type error, fix 'OBJECT_ADDITIONAL_PROPERTIES' error, add …
Dec 7, 2017
403d68d
Add datePublished property back
Dec 8, 2017
e8f7a6d
Add _type value in examples
Dec 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions specification/cognitiveservices/data-plane/NewsSearch/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ These settings apply only when `--tag=release_1_0` is specified on the command l
input-file: v1.0/NewsSearch.json
```

## Suppressions

Suppressing errors due to API design:
``` yaml
directive:
- suppress: R3016
reason: _type is a polymorphic discriminator that can't be changed.
```

## CSharp Settings
These settings apply only when `--csharp` is specified on the command line.
``` yaml $(csharp)
Expand Down
157 changes: 89 additions & 68 deletions specification/cognitiveservices/data-plane/NewsSearch/v1.0/NewsSearch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,7 @@
}
},
"SearchResultsAnswer": {
"description": "Defines a search result answer.",
"allOf": [
{
"$ref": "#/definitions/Answer"
Expand Down Expand Up @@ -714,6 +715,7 @@
}
},
"Answer": {
"description": "Defines an answer.",
"allOf": [
{
"$ref": "#/definitions/Response"
Expand Down Expand Up @@ -747,6 +749,7 @@
}
},
"Thing": {
"description": "Defines a thing.",
"allOf": [
{
"$ref": "#/definitions/Response"
Expand All @@ -765,6 +768,7 @@
"type": "string"
},
"image": {
"description": "An image of the item.",
"$ref": "#/definitions/ImageObject",
"readOnly": true
},
Expand All @@ -789,6 +793,7 @@
"type": "string"
},
"alternateName": {
"description": "An alias for the item",
"readOnly": true,
"type": "string"
},
Expand Down Expand Up @@ -829,10 +834,12 @@
"type": "string"
},
"searchLink": {
"description": "The URL that you use to get the results of the related search. Before using the URL, you must append query parameters as appropriate and include the Ocp-Apim-Subscription-Key header. Use this URL if you're displaying the results in your own user interface. Otherwise, use the webSearchUrl URL.",
"readOnly": true,
"type": "string"
},
"thumbnail": {
"description": "The URL to a thumbnail of a related image.",
"$ref": "#/definitions/ImageObject",
"readOnly": true
}
Expand Down Expand Up @@ -874,75 +881,8 @@
}
}
},
"ImageObject": {
"description": "Defines an image",
"allOf": [
{
"$ref": "#/definitions/MediaObject"
}
],
"type": "object",
"properties": {
"thumbnail": {
"description": "The URL to a thumbnail of the image",
"$ref": "#/definitions/ImageObject",
"readOnly": true
}
}
},
"VideoObject": {
"description": "Defines a video object that is relevant to the query.",
"allOf": [
{
"$ref": "#/definitions/MediaObject"
}
],
"type": "object",
"properties": {
"motionThumbnailUrl": {
"readOnly": true,
"type": "string"
},
"motionThumbnailId": {
"readOnly": true,
"type": "string"
},
"embedHtml": {
"readOnly": true,
"type": "string"
},
"allowHttpsEmbed": {
"readOnly": true,
"type": "boolean"
},
"viewCount": {
"readOnly": true,
"type": "integer",
"format": "int32"
},
"thumbnail": {
"$ref": "#/definitions/ImageObject",
"readOnly": true
},
"videoId": {
"readOnly": true,
"type": "string"
},
"allowMobileEmbed": {
"readOnly": true,
"type": "boolean"
},
"isSuperfresh": {
"readOnly": true,
"type": "boolean"
},
"isFromVerifiedSource": {
"readOnly": true,
"type": "boolean"
}
}
},
"CreativeWork": {
"description": "The most generic kind of creative work, including books, movies, photographs, software programs, etc.",
"allOf": [
{
"$ref": "#/definitions/Thing"
Expand All @@ -964,6 +904,7 @@
}
},
"datePublished": {
"description": "The date on which the CreativeWork was published.",
"readOnly": true,
"type": "string"
},
Expand All @@ -973,6 +914,32 @@
}
}
},
"Organization": {
"description": "Defines an organization.",
"allOf": [
{
"$ref": "#/definitions/Thing"
}
],
"type": "object",
"properties": {}
},
"ImageObject": {
"description": "Defines an image",
"allOf": [
{
"$ref": "#/definitions/MediaObject"
}
],
"type": "object",
"properties": {
"thumbnail": {
"description": "The URL to a thumbnail of the image",
"$ref": "#/definitions/ImageObject",
"readOnly": true
}
}
},
"Identifiable": {
"description": "Defines the identity of a resource.",
"allOf": [
Expand Down Expand Up @@ -1011,6 +978,7 @@
}
},
"MediaObject": {
"description": "Defines a media object.",
"allOf": [
{
"$ref": "#/definitions/CreativeWork"
Expand All @@ -1037,7 +1005,60 @@
}
}
},
"VideoObject": {
"description": "Defines a video object that is relevant to the query.",
"allOf": [
{
"$ref": "#/definitions/MediaObject"
}
],
"type": "object",
"properties": {
"motionThumbnailUrl": {
"readOnly": true,
"type": "string"
},
"motionThumbnailId": {
"readOnly": true,
"type": "string"
},
"embedHtml": {
"readOnly": true,
"type": "string"
},
"allowHttpsEmbed": {
"readOnly": true,
"type": "boolean"
},
"viewCount": {
"readOnly": true,
"type": "integer",
"format": "int32"
},
"thumbnail": {
"$ref": "#/definitions/ImageObject",
"readOnly": true
},
"videoId": {
"readOnly": true,
"type": "string"
},
"allowMobileEmbed": {
"readOnly": true,
"type": "boolean"
},
"isSuperfresh": {
"readOnly": true,
"type": "boolean"
},
"isFromVerifiedSource": {
"readOnly": true,
"type": "boolean"
}
}
},
"ResponseBase": {
"description": "Response base",
"discriminator": "_type",
"type": "object",
"required": [
Expand Down
Loading