Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a url option when executing image action #1426

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

minhnhatspk
Copy link

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets no
License MIT

Description

[Description of the bug or feature]
when i use execAction('image'), i don't see any options in your guide to put an url to this method.
so i decided to create my own one.
my use case: I handled image from clipboard, upload it to server and response an url, then i show it on medium editor by execAction('image',{url: 'https://mywebsite.com/example.jpg'}).
if you see it useful, you can merge this request.
and if my changed is bad, please improve it and update your readme.md.
Thank.

--

@coveralls
Copy link

coveralls commented Mar 9, 2018

Coverage Status

Coverage remained the same at 94.469% when pulling b10b7a3 on minhnhatspk:master into 3fcd1b2 on yabwe:master.

Copy link
Contributor

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert the dist/* changes?
Could you also add a test to cover the options url attributes?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants