Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support incremental backups #212

Merged
merged 6 commits into from
Jan 27, 2024
Merged

Support incremental backups #212

merged 6 commits into from
Jan 27, 2024

Conversation

posriniv
Copy link
Collaborator

@posriniv posriniv commented Jan 25, 2024

bash-5.2$ export YBM_FF_INCREMENTAL_BACKUP=true
bash-5.2$ ./ybm backup policy list --cluster-name super-trout
Time Interval(days)   Incr. Interval(mins)   Days of the Week   Backup Start Time   Retention Period(days)   State
NA                    NA                     Su,Sa              15:40               8                        ACTIVE
bash-5.2$ ./ybm backup policy update --cluster-name super-trout --retention-period-in-days=8 --full-backup-frequency-in-days=5 --incremental-backup-frequency-in-minutes=60
Successfully updated backup policy for cluster super-trout
bash-5.2$ ./ybm backup policy list --cluster-name super-trout
Time Interval(days)   Incr. Interval(mins)   Days of the Week   Backup Start Time   Retention Period(days)   State
5                     60                     NA                 NA                  8                        ACTIVE
bash-5.2$ ./ybm backup policy disable --cluster-name super-trout
Successfully disabled backup policy for cluster super-trout
bash-5.2$ ./ybm backup policy list --cluster-name super-trout
Time Interval(days)   Incr. Interval(mins)   Days of the Week   Backup Start Time   Retention Period(days)   State
5                     60                     NA                 NA                  8                        PAUSED
bash-5.2$ ./ybm backup policy enable --cluster-name super-trout
Successfully enabled backup policy for cluster super-trout
bash-5.2$ ./ybm backup policy list --cluster-name super-trout
Time Interval(days)   Incr. Interval(mins)   Days of the Week   Backup Start Time   Retention Period(days)   State
5                     60                     NA                 NA                  8                        ACTIVE

@posriniv posriniv requested a review from a team as a code owner January 25, 2024 20:20
Copy link
Contributor

@cdavid cdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check this still works against PROD.

internal/client/client.go Outdated Show resolved Hide resolved
internal/formatter/backup_policy_list.go Outdated Show resolved Hide resolved
Copy link

@karthik-chandrasekaran karthik-chandrasekaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it would be a good to include screenshots/text of how the CLI input/output looks (similar to UI PRs) as part of CLI PRs

Cc: @cdavid

@posriniv
Copy link
Collaborator Author

In general it would be a good to include screenshots/text of how the CLI input/output looks (similar to UI PRs) as part of CLI PRs

Cc: @cdavid

Done now.

@posriniv
Copy link
Collaborator Author

Please double check this still works against PROD.

Done!

@posriniv posriniv merged commit 400b247 into main Jan 27, 2024
2 checks passed
@posriniv posriniv deleted the posriniv/incremental-backup branch January 27, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants