Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDGA-20741] Add support for cluster-name in DB audit #229

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[CLOUDGA-20741] Add support for cluster-name in DB audit #229

merged 1 commit into from
Apr 23, 2024

Conversation

aquatiko
Copy link
Contributor

Summary

This change replaces cluster-id with cluster-name in DB audit commands. This is done to maintain uniformity with other commands

Test Plan

Added UTs for the change.
Verified docs by turning on the feature flag
Manually tested the commands

@aquatiko aquatiko requested a review from a team as a code owner April 23, 2024 10:17
posriniv
posriniv approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@posriniv posriniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aquatiko aquatiko merged commit e3c3183 into main Apr 23, 2024
2 checks passed
@aquatiko aquatiko deleted the CLOUDGA-20741 branch April 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiyatiSinha-yb NiyatiSinha-yb NiyatiSinha-yb left review comments

@posriniv posriniv posriniv approved these changes

@jagdish-yb jagdish-yb jagdish-yb approved these changes

@shinji62 shinji62 Awaiting requested review from shinji62

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aquatiko @posriniv @NiyatiSinha-yb @jagdish-yb