Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Early Access track to the docs #235

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Add Early Access track to the docs #235

merged 3 commits into from
Jul 9, 2024

Conversation

posriniv
Copy link
Collaborator

@posriniv posriniv commented Jul 9, 2024

No description provided.

@posriniv posriniv requested a review from a team as a code owner July 9, 2024 18:34
@VijiYB
Copy link

VijiYB commented Jul 9, 2024

@posriniv How can we make sure that user mention Early Access within double quotes to treat that as a single word.

@posriniv
Copy link
Collaborator Author

posriniv commented Jul 9, 2024 •
edited
Loading

@posriniv How can we make sure that user mention Early Access within double quotes to treat that as a single word.

@VijiYB I will make a change to show a quoted string in the CLI help. Maybe we can add it to the docs specifically too. cc: @ddhodge

ddhodge
ddhodge approved these changes Jul 9, 2024
View reviewed changes
Copy link

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

cmd/cluster/create_cluster.go Outdated Show resolved Hide resolved
cmd/cluster/update_cluster.go Outdated Show resolved Hide resolved
docs/ybm_cluster_create.md Outdated Show resolved Hide resolved
docs/ybm_cluster_update.md Outdated Show resolved Hide resolved
docs/ybm.md Outdated Show resolved Hide resolved
@posriniv posriniv requested a review from juanman2 July 9, 2024 19:41
@posriniv posriniv merged commit f89f994 into main Jul 9, 2024
2 checks passed
@posriniv posriniv deleted the posriniv/cluster-tracks branch July 9, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddhodge ddhodge ddhodge approved these changes

@VijiYB VijiYB Awaiting requested review from VijiYB

@daniel-yb daniel-yb Awaiting requested review from daniel-yb

@juanman2 juanman2 Awaiting requested review from juanman2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@posriniv @VijiYB @juanman2 @ddhodge