[CLOUDGA-22927][CLOUDGA-22911] Updated GET call to use latest API and added FF for GCP integration #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagdish-yb
reviewed
Sep 9, 2024
arishta-yb
approved these changes
Sep 9, 2024
Siddarth-Baldwa
force-pushed
the
sbaldwa/22927-22911
branch
from
8ad5c2e
to
a1d31f9
Compare
jagdish-yb
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CLOUDGA 22927
The delete call used metrics-exporter list API to fetch the telemetry provider using config-id (uuid). However, old APIs do not recognise GoogleCloud Enum, hence resulted in errors. As part of this change we use the latest APIs in the GET call
CLOUDGA 22911
Added the FF for google cloud integration (telemetry provider). Following are the cases and their respective behaviour
Note - GoogleCloud FF = false
a. Using correct full command
b. Using unknown flag
c. Using correct but inconsistent flags- Eg: If this case is not handled, the error thrown will as for
--googlecloud-cred-filepathflag even after setting the FF tofalseTest