Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix go vet detected issues #31

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Conversation

shinji62
Copy link
Collaborator

Removed some of the Go vet reported issues
Removed line return \n which is not necessary and may break error display as well

Etourneau Gwenn added 2 commits January 27, 2023 09:57
Remove line return which may break display when using logrus.Errorf
Copy link
Collaborator

@posriniv posriniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shinji62 shinji62 merged commit 8c1a346 into main Jan 27, 2023
@posriniv posriniv deleted the fix/fix_go_vet_detected_issues branch February 7, 2023 03:06
cdavid pushed a commit that referenced this pull request Feb 23, 2023
* Fixed go vet reported issue
* Remove line return which may break display when using logrus.Errorf
* Added client.go
* Adding to vet to the flow
* Fixed cluster.go

Former-commit-id: 6b56d130344eb2f9b87f376100e8ef9921846bf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants