Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to the CLI #58

Merged
merged 7 commits into from
Feb 13, 2023
Merged

Enhancements to the CLI #58

merged 7 commits into from
Feb 13, 2023

Conversation

posriniv
Copy link
Collaborator

@posriniv posriniv commented Feb 10, 2023 •
edited
Loading

  • Change cluster tier from FREE to Sandbox and PAID to Dedicated.
  • Change database-track to database-version
  • Mark flags as REQUIRED or OPTIONAL
  • Improve description of commands and flags
  • Make the error handling better

@posriniv posriniv changed the title Change cluster tier to Sandbox and Dedicated Enhancements to the CLI Feb 10, 2023
shinji62
shinji62 reviewed Feb 13, 2023
View reviewed changes
cmd/cdc/cdc_sink.go Outdated Show resolved Hide resolved
shinji62
shinji62 reviewed Feb 13, 2023
View reviewed changes
cmd/cdc/cdc_sink.go Outdated Show resolved Hide resolved
shinji62
shinji62 reviewed Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@shinji62 shinji62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment

cdavid
cdavid reviewed Feb 13, 2023
View reviewed changes
cmd/cdc/cdc_stream.go Outdated Show resolved Hide resolved
cmd/cluster/instance_types.go Outdated Show resolved Hide resolved
@posriniv posriniv merged commit b2b0259 into main Feb 13, 2023
@posriniv posriniv deleted the posriniv/cluster-tier branch February 13, 2023 19:41
cdavid pushed a commit that referenced this pull request Feb 23, 2023
@posriniv
Enhancements to the CLI (#58)
4d46fa7 
Former-commit-id: e95d3ca858a329aab43cfa74a1b3344025d9bff1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavid cdavid cdavid approved these changes

@shinji62 shinji62 Awaiting requested review from shinji62

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@posriniv @cdavid @shinji62