single-region cluster crud operations #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posriniv
force-pushed
the
posriniv/cluster-crud
branch
from
d1cdbda
to
4c242d6
Compare
Aliqyan
reviewed
Sep 23, 2022
cmd/util.go
Outdated
| @@ -38,6 +40,23 @@ func getApiClient(ctx context.Context) (*ybmclient.APIClient, error) { | |||
| return apiClient, nil | |||
| } | |||
|
|
|||
| func getClusterID(ctx context.Context, apiClient *ybmclient.APIClient, accountId string, projectId string, clusterName string) (clusterId string, clusterIdOk bool, errorMessage string) { | |||
| clusterResp, resp, err := apiClient.ClusterApi.ListClusters(ctx, accountId, projectId).Execute() | |||
There was a problem hiding this comment.
nit. you could change to apiClient.ClusterApi.ListClusters(ctx, accountId, projectId).Name(clusterName).Execute() to skip the for loop
Aliqyan
reviewed
Sep 23, 2022
| fmt.Fprintf(os.Stderr, "Full HTTP response: %v\n", r) | ||
| return | ||
| } | ||
| populateFlags(cmd, originalSpec, trackName) |
There was a problem hiding this comment.
This seems weird to repopulate the flags with the data from the get request. I think it would be better to write some extra logic to validate that the get response has valid data (if not overwritten by the user).
Is there any other benefit of populating the flags?
There was a problem hiding this comment.
Yeah, there is. This will allow us to re-use the createClusterSpec code.
posriniv
changed the title
cdavid
pushed a commit
that referenced
this pull request
Feb 23, 2023
Former-commit-id: 8db0cea55583ab4249e86dcbdeaf05f1d8d9589e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.