Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve docker environment #1453

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

ABGEO
Copy link
Contributor

@ABGEO ABGEO commented Jun 2, 2023

web-ui

  • Fix heathcheck by installing curl
  • Move the build process to the docker container (no local Yarn needed anymore)

server

  • Use multi-stage docker build to generate server .jar

Docker Compose

  • Fix formatting
  • Add volume for postgres container to preserve the state
  • Improve caching

@ABGEO ABGEO requested a review from tkrop as a code owner June 2, 2023 11:24
@ABGEO
Copy link
Contributor Author

ABGEO commented Jun 26, 2023

ping

@chamoda
Copy link

chamoda commented Nov 22, 2023

If anyone get the error ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref ea1c9a0c-1d43-4ea5-9790-ed1882c85fce::zarskmsx0awdlxwwmljsqcv1u: "/zally-server/build/libs/zally-server.jar": not found on main branch docker-compose up, this PR also fix that issue.

@tkrop
Copy link
Member

tkrop commented Dec 4, 2023

👍

@tkrop
Copy link
Member

tkrop commented Dec 4, 2023

@ABGEO Sorry that it took so long. Thank you for your contribution. I was a bit hesitant to merge this, because we intend to remove the Web UI, since it is unmaintained, heavily outdated, and has many vulnerabilities.

@tkrop tkrop closed this Dec 14, 2023
@tkrop tkrop reopened this Dec 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6a810e) 77.11% compared to head (62ac6c8) 77.11%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1453   +/-   ##
=========================================
  Coverage     77.11%   77.11%           
  Complexity      669      669           
=========================================
  Files           171      171           
  Lines          2819     2819           
  Branches        442      442           
=========================================
  Hits           2174     2174           
  Misses          417      417           
  Partials        228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktsypkina
Copy link
Member

👍

@ktsypkina
Copy link
Member

tested changes, works on my local as well 👍

@tkrop tkrop merged commit bae01b9 into zalando:main Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants