This repository has been archived by the owner on Jan 1, 2020. It is now read-only.
Use script for updating .gitignore #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
force-pushed
the
hotfix/450-cross-compat-gitignore
branch
2 times, most recently
from
9071546
to
497c816
Compare
Due to quoting issues between different operating systems, the script for removing the `composer.lock` entry from the `.gitignore` file was not working on Linux after a recent update to provide support for Windows. To provide a truly cross-platform way to work, this patch provides a script, `bin/update-gitignore`, which does the work. The `composer.json` entry is updated to call that script, which deletes itself on completion.
weierophinney
force-pushed
the
hotfix/450-cross-compat-gitignore
branch
from
497c816
to
edae8ac
Compare
weierophinney
added a commit
that referenced
this pull request
Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to quoting issues between different operating systems, the script for removing the
composer.lockentry from the.gitignorefile was not working on Linux after a recent update to provide support for Windows. To provide a truly cross-platform way to work, this patch provides a script,bin/update-gitignore, which does the work. Thecomposer.jsonentry is updated to call that script, which deletes itself on completion.Fixes #450