For error reporting, assume a struct is not a tuple when ambiguous #20762
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tau-dev
force-pushed
the
improve-struct-tuple-errors
branch
from
1c49559
to
0c0945a
Compare
Fixes ziglang#14334: non-tuples are more common, and forgetting a type or name from a struct field is an easier mistake to make than adding a name to a tuple field.
tau-dev
force-pushed
the
improve-struct-tuple-errors
branch
from
0c0945a
to
fd119ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14334: non-tuples are more common, and forgetting a type or name from a struct field is an easier mistake to make than adding a name to a tuple field.