Some additions to std.elf addressing #19830, plus some zld improvements
#21573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have no callers outside std.elf. Even if the standard library should provide functions like these, std.elf is probably not the place, given how general they are.
Rexicon226
reviewed
Oct 3, 2024
Rexicon226
reviewed
Oct 3, 2024
| /// NVIDIA CUDA architecture | ||
| CUDA = 51, | ||
| /// AMD HSA Runtime | ||
| AMDGPU_HSA = 64, |
There was a problem hiding this comment.
For OSABI values > 64, they become dependent on the machine header, and so can overlap. Could we maybe, move them to be decls with multiple having the same value?
There was a problem hiding this comment.
The pattern we usually use in situations like this is to have the most common name be the proper enum tag and the uncommon ones be decls defined as that enum tag. That seems reasonable to do here.
kubkon
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19830.