Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(JsonCodec): codec derivation on nested types #1139

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix(JsonCodec): codec derivation on nested types #1139

merged 1 commit into from
Aug 15, 2024

Conversation

ifndev
Copy link
Contributor

@ifndev ifndev commented Jul 29, 2024 •
edited
Loading

This is a fix for issue #1128 , see details in issue comments
(Review needed, I am not familiar with this codebase)

  • 'encoder' parameter is now explicit for 'fromEncoderDecoder'
  • removed version-specific variants that were used to work around a test

/claim #1128

@ifndev ifndev requested a review from a team as a code owner July 29, 2024 13:45
@algora-pbc algora-pbc bot mentioned this pull request Jul 29, 2024
Closed
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ifndev ifndev marked this pull request as draft July 29, 2024 13:47
@ifndev ifndev marked this pull request as ready for review July 29, 2024 13:58
@fsvehla fsvehla merged commit 0a555ac into zio:series/2.x Aug 15, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsvehla fsvehla fsvehla approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ifndev @CLAassistant @fsvehla