New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash implementation to scalar #118

Open

HDauven wants to merge 1 commit into zkcrypto:main from HDauven:scalar-hash-equality

HDauven commented Oct 18, 2023

Upstream, we make use of Hash derive on Scalar.

Scalar uses a custom PartialEq for constant-time comparison, but derives Hash, which leads to this Clippy warning downstream for us.

My proposed solution is to implement a custom Hash for Scalar that standardizes on the underlying values. A test is added to ensure consistency.


          Add hash impl to scalar

69f0ae1

HDauven mentioned this pull request

Add hash implementation to scalar dusk-network/bls12_381#127

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet