Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legendre Symbol #93

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

SteinerMatthias
Copy link

Implemented the legendre symbol for BLS12-381 base and scalar fields.

implemented Legendre Symbol for BLS12_381 scalar field
implemented Legendre Symbol for BLS12_381 base field
@ebfull
Copy link
Contributor

ebfull commented Dec 8, 2022

I had a couple comments.

We don't expose Fp in the crate so there's no need to implement this for Fp since we don't need it internally.

Also, you can just call sqrt and if it returns a valid CtOption you'll know if it's square. Do you have a particular need to more efficiently check whether it's a square outside of the context of computing square roots?

@huitseeker
Copy link

@ebfull the classical example would be the Shallue-van de Woestijne map to the curve, I think, but I don't know if this is very relevant for BLS12-381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants