Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user classification counts filtering by project if session time is false. do not return session time as key in response #36

Conversation

yuenmichelle1
Copy link
Collaborator

Small bug found:
eg.
https://eras-staging.zooniverse.org/classifications/users/1234?start_date=2022-03-10&project_id=1974&period=day

returns

{
    "total_count": 24,
    "data": [
        {
            "period": "2022-09-09T00:00:00.000Z",
            "count": 23,
            "session_time": null
        },
        {
            "period": "2022-09-20T00:00:00.000Z",
            "count": 1,
            "session_time": null
        }
    ]
}

This PR makes sure session_time is not a key in response data when time_spent=true

… when filtering user classification counts by project, session_time is not returned as a key
…me calculation if time_spent is false (and when not project_contributions=true)
…by-project-if-session_time-is-false.-do-not-return-session-time-key
@yuenmichelle1 yuenmichelle1 merged commit 6198953 into main Oct 2, 2023
4 checks passed
@yuenmichelle1 yuenmichelle1 deleted the update-user-classification-counts-filtering-by-project-if-session_time-is-false.-do-not-return-session-time-key branch October 19, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant