Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty values in file column #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow empty values in file column #177

wants to merge 1 commit into from

Conversation

timstallmann
Copy link

I'm trying to upload a subject set where different subjects have differing values of files, and was getting an error relating to validate_file being called and causing the whole import to fail when it didn't find a null file.

This PR modifies the subject-set upload-subjects command to:

  • Skips any upload filename which is the empty string entirely
  • When validate_file fails, skip that filename and continue with the rest of the upload

@timstallmann
Copy link
Author

Hi! Just a ping to see if anyone would be able to review this?

@lcjohnso lcjohnso self-assigned this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcjohnso lcjohnso

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timstallmann @lcjohnso