Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Instance October Swagger #4058

Merged
merged 5 commits into from
Oct 2, 2018
Merged

Container Instance October Swagger #4058

merged 5 commits into from
Oct 2, 2018

Conversation

samkreter
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 2, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3489

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 2, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 2, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3753

@AutorestCI
Copy link

AutorestCI commented Oct 2, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1621

@AutorestCI
Copy link

AutorestCI commented Oct 2, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2292

@AutorestCI
Copy link

AutorestCI commented Oct 2, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2894

jhendrixMSFT
jhendrixMSFT requested changes Oct 2, 2018
View reviewed changes
...stance/resource-manager/Microsoft.ContainerInstance/stable/2018-10-01/containerInstance.json Outdated
"required": [
"properties"
],
"identity": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the wrong place and is the cause for the autorest codegen to fail. Presumably this is supposed to go under properties?

This was referenced Oct 2, 2018
Merged
Merged
Merged
Merged
Merged
jhendrixMSFT
jhendrixMSFT reviewed Oct 2, 2018
View reviewed changes
...er/Microsoft.ContainerInstance/stable/2018-10-01/examples/ContainerGroupsCreateOrUpdate.json Outdated
@@ -8,6 +8,12 @@
"id": "/subscriptions/subid/resourceGroups/demo/providers/Microsoft.ContainerInstance/containerGroups/demo1",
"location": "west us",
"name": "demo1",
"Identity": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example also needs to be updated after your last commit, see the failure in the model validator log.

@jhendrixMSFT jhendrixMSFT mentioned this pull request Oct 2, 2018
Closed
@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Oct 2, 2018 •
edited
Loading

Issue Azure/azure-openapi-validator#176 to track what I believe is a false positive linter error.

jhendrixMSFT
jhendrixMSFT reviewed Oct 2, 2018
View reviewed changes
...er/Microsoft.ContainerInstance/stable/2018-10-01/examples/ContainerGroupsCreateOrUpdate.json Outdated
"name": "demo1",
"identity": {
"type": "SystemAssigned, UserAssigned",
"UserAssignedIdentities": {
Copy link
Member

@jhendrixMSFT jhendrixMSFT Oct 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing for this one is also wrong, see log. You can run the validation locally, see instructions here.

@jhendrixMSFT jhendrixMSFT mentioned this pull request Oct 2, 2018
Closed
@samkreter samkreter force-pushed the sakreter-AddingOctoberSwagger branch from 17d26ec to 060f19a Compare October 2, 2018 20:43
@jhendrixMSFT jhendrixMSFT merged commit da7505b into Azure:master Oct 2, 2018
@samkreter samkreter mentioned this pull request Oct 9, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samkreter @AutorestCI @azuresdkci @jhendrixMSFT