Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect subdomains #47

Closed
sberdyshev opened this issue Mar 15, 2019 · 4 comments
Closed

Incorrect subdomains #47

sberdyshev opened this issue Mar 15, 2019 · 4 comments
Assignees
@echerniak
Labels
code Concerns code docs Concerns documentation invalid This doesn't seem right
Milestone
Release 0.2.0.

Comments

@sberdyshev
Copy link
Contributor

Metrics mqobject_get_average_queue_time_microseconds, mqobject_get_queue_depth_messages have to have different subdomain - queue.

Moreover, all the metrics in readme file have to be checked if they belong to correct section. Specific sections can be created if they don't exist.
@sberdyshev sberdyshev added invalid This doesn't seem right docs Concerns documentation labels Mar 15, 2019
@sberdyshev sberdyshev added this to the Release 1.0.0. milestone Mar 15, 2019
@sberdyshev sberdyshev added the code Concerns code label Mar 15, 2019
@sberdyshev sberdyshev mentioned this issue Mar 16, 2019
Closed
5 tasks
@sberdyshev
Copy link
Contributor Author

depends on #7 - new metric names affect changes in #7

This was referenced Mar 16, 2019
Closed
Closed
@sberdyshev
Copy link
Contributor Author

relates to #53 #54

@sberdyshev
Copy link
Contributor Author

intersects with #51 in readme.md

@echerniak echerniak self-assigned this Mar 18, 2019
echerniak added a commit that referenced this issue Mar 19, 2019
@echerniak
issue53 metric names updated. Resolves: #47, #53, #54
0886ca0
@echerniak
Copy link
Contributor

Also updated these metrics:
mqobject_get_messages_expired_totalmessages -> mqobject_queue_messages_expired_totalmessages
mqobject_get_queue_purged_count_totalqueues -> mqobject_queue_queue_purged_count_totalqueues

@echerniak echerniak mentioned this issue Mar 19, 2019
Merged
echerniak added a commit that referenced this issue Mar 20, 2019
@echerniak
issue53 metric names updated. Resolves: #47, #51, #53, #54
7d61069
echerniak added a commit that referenced this issue Mar 20, 2019
@echerniak
issue53 metric names updated. Resolves: #47, #51, #53, #54
a9e8bb6
echerniak added a commit that referenced this issue Mar 20, 2019
@echerniak
issue53 metric names updated. Resolves: #47, #53, #54
c0c728e
@echerniak echerniak added the waiting to be tested An issue or a pull request has been developed and is ready for testing label Mar 20, 2019
@sberdyshev sberdyshev removed the waiting to be tested An issue or a pull request has been developed and is ready for testing label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echerniak echerniak

Labels
code Concerns code docs Concerns documentation invalid This doesn't seem right
Projects
None yet
Milestone
Release 0.2.0.
Development

No branches or pull requests
2 participants
@echerniak @sberdyshev