Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue53, issue54, issue47, issue51 wrong subdomain #66

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

echerniak
Copy link
Contributor

@echerniak echerniak commented Mar 19, 2019

Resolves: #47, #53, #54
Contains #51

@echerniak echerniak added docs Concerns documentation code Concerns code labels Mar 19, 2019
@echerniak echerniak added this to the Release 0.2.0. milestone Mar 19, 2019
@echerniak echerniak self-assigned this Mar 19, 2019
@echerniak echerniak changed the title Feature/issue53 wrong subdomain Feature/issue53, issue54, issue47 wrong subdomain Mar 19, 2019
Copy link
Contributor

@sberdyshev sberdyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table in readme is "incorrect":

image

Copy link
Contributor

@sberdyshev sberdyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more problem in the same table:

image

README.md Outdated
<td>Disk usage metrics</td>
</tr>
<tr>
<td rowspan="15">mq</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change in rowspan will help

@echerniak echerniak changed the title Feature/issue53, issue54, issue47 wrong subdomain Feature/issue53, issue54, issue47, issue51 wrong subdomain Mar 20, 2019
@echerniak echerniak force-pushed the feature/issue53_wrong_subdomain branch from 0886ca0 to 7d61069 Compare March 20, 2019 17:04
@echerniak echerniak force-pushed the feature/issue53_wrong_subdomain branch from 7d61069 to a9e8bb6 Compare March 20, 2019 17:10
@sberdyshev sberdyshev merged commit abcbba6 into develop Mar 20, 2019
@echerniak echerniak deleted the feature/issue53_wrong_subdomain branch March 21, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Concerns code docs Concerns documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants