-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work in progress: reverted code to render tabs #2084
Open
ashwiniHerle
wants to merge
80
commits into
update-bootstrap-ui-library
Choose a base branch
from
wip--sample-details-conflicting-changes
base: update-bootstrap-ui-library
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
work in progress: reverted code to render tabs #2084
ashwiniHerle
wants to merge
80
commits into
update-bootstrap-ui-library
from
wip--sample-details-conflicting-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
display dummy state for navigation
* Use react state to store/access form field values * Fix variable case * Update MoleculeModerator.js to new bootstrap version * Update MoleculeModeratorComponent.js to new bootstrap version * Use react state to store/access form field values again
* replace legacy components with local versions display dummy state for navigation * Update button properties * Migrate SampleForm * Update button properties * use variant light to display white buttons * change margin spacing * refactor comment modal * admin: corrected semicolon from send message button * refactor mydb-app.js to latest react bootstrap * refactor reactions-scheme tab * refactor reactions-properties tab * refactor reactiondetailsproperties * refactor reactiondetails container * refactor reactionDetails * refactor hyperlinkssection * refactor container dataset components * refactor greenmaterialgroup to latest react bootstrap * remove external css class - waste-chkbx * fix for the scrolling issue * reordered buttons using button toolbar * aligned delete buttons and style changes * added button toolbar and changed spacing --------- Co-authored-by: Joachim Tillessen <tillessen@emjot.de>
* Fix styles for Admin device list * Fix basic styles for admin device modal * Fix device modal * Fix scrollable content height
bootstrap upgrade - admin and reactions bugfixes and removed unused legacy imports
update bootstrap: researchplans and structure editor modal
* Minor formatting fixes in ElementDetails.js * shouldComponentUpdate returns true by default * Use destructuring assignment for React state * Replace legacy bootstrap Label with Badge * Remove unused function * Prefer absolute import path * Remove obsolete resize handling * Use state and props destructuring assignment * Update ElementDetailSortTab to new react bootstrap * Fix ElementDetailSortTab button position Moving button positioning to the parent container would require refactoring all detail views that use it. Because of that we are falling back to positioning via float, as it was done before the bootstrap update. * Use `type` prop directly * Rename ExportSamplesBtn => ExportSamplesButton * Update ExportSamplesButton * Inline button * Update NumericInputUnit to new bootstrap version * Update PrivateNoteElement to new bootstrap version * Fix some linter complaints in PrivateNoteElement * Minor style fixes in LiteratureDetails * Use utility classes in NumericInputUnit and fix tests * Translate LiteratureDetails Panel to Card * Translate LiteratureDetails Panel/PanelGroup to Accordion * Use utility classes instead of in LiteratureDetails * Minor style changes and removal of unused vars/attributes * Update GraphContainer to new bootstrap version
* Remove unused method in CellLineDetails * Update CellLineDetails to new bootstrap version * Change cell line GeneralProperties PanelGroup to Accordion * Translate Form in GeneralProperties and CellLineName * Use utility classes in InvalidPropertyWarning * Use utility classes for Amount, separate logic and markup * Update AnalysesContainer button placement to utility classes * Update AnalysesContainer to new bootstrap version Also consolidate EditModeHeader and OrderModeHeader into a single Header component. * Remove unused css rule * Translate custom css to utility class * Style analysesTab Header using utility classes
* refactor inbox components * reduce the size of comment button * refactor collection and researchplan labels to latest react-bootstrap * fix the sizes of inboxModal
* Fix screen properties tab and screen wellplates * Fix screen research plan tab * Fix screen analyses tab and rounded card header * Fix toggle analyses accordion when clicking on buttons * Fix analyses quill editor and text template icon * Fix quill editor * Fix deprecated componentWillReceiveProps * Fix research plan flow display and Modal * Fix draggable modal with other sizes * Add dropzone to screen wellplate, unique style for dropzones * Remove unused functions, Fix border color * Fix loading modal * Fix styles for flow editor
* Update UserAuth and GroupElement to new bootstrap version, utility classes * Minor style and formatting fixes * Remove redundant early return The Modal's show property will handle showing and hiding * Update NavNewSession to new bootstrap version Also do not render emtpy <Col>s * Add code review feedback
* Update ReportComponent to new bootstrap version * Update Report Details Config to new bootstrap version * Update Report detail Setting to new bootstrap version * Update Report Orders and OrdersDnD to new bootstrap version * Update Report Archives to new bootstrap version * Update Report Serials to new bootstrap version * Minor formatting and proper React keys in Report Previews * Minor code style changes in SectionReactionList * proper React keys for rows * filter first, then map * fewer parameters for rowContent * `el.description` can be an empty object * Update Report Preview SectionReaction to new bootstrap version * Update Report Preview headers in SectionReaction, SectionSample * Remove lodash dependency from Report Preview components and minor simplifications * Use `responsive` Table attribute instead of utility class * Add code review feedback
maiwald
force-pushed
the
update-bootstrap-ui-library
branch
from
August 27, 2024 07:15
51777c5
to
20fc105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.