Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crashed by an assertion in common/gossmap.c in v0.12.0 #5578

Closed
heyambob opened this issue Sep 8, 2022 · 0 comments · Fixed by #5593
Closed

crashed by an assertion in common/gossmap.c in v0.12.0 #5578

heyambob opened this issue Sep 8, 2022 · 0 comments · Fixed by #5593
Assignees
@rustyrussell
Milestone
v0.12.1

Comments

@heyambob
Copy link

heyambob commented Sep 8, 2022

Issue and Steps to Reproduce

So far it happened once. A little bit after restarted while I had some problem with tor, unsure if related.

topology: common/gossmap.c:419: add_channel: Assertion `!private' failed.
topology: FATAL SIGNAL 6 (version v0.12.0)
0x561f49f56244 send_backtrace
	common/daemon.c:33
0x561f49f562ec crashdump
	common/daemon.c:46
0x7f571843e8df ???
	???:0
0x7f571848e36c ???
	???:0
0x7f571843e837 ???
	???:0
0x7f5718428534 ???
	???:0
0x7f571842845b ???
	???:0
0x7f5718437365 ???
	???:0
0x561f49f2e72d add_channel
	common/gossmap.c:419
0x561f49f2ef3d map_catchup
	common/gossmap.c:618
0x561f49f3002f gossmap_refresh
	common/gossmap.c:938
0x561f49f3b5fa get_gossmap
	plugins/topology.c:27
0x561f49f3d389 json_listnodes
	plugins/topology.c:525
0x561f49f42245 ld_command_handle
	plugins/libplugin.c:1452
0x561f49f42398 ld_read_json_one
	plugins/libplugin.c:1493
0x561f49f424ca ld_read_json
	plugins/libplugin.c:1513
0x561f49fdea0b next_plan
	ccan/ccan/io/io.c:59
0x561f49fdf5d6 do_plan
	ccan/ccan/io/io.c:407
0x561f49fdf614 io_ready
	ccan/ccan/io/io.c:417
0x561f49fe18de io_loop
	ccan/ccan/io/poll.c:453
0x561f49f42f63 plugin_main
	plugins/libplugin.c:1710
0x561f49f3dac2 main
	plugins/topology.c:701
0x7f571842928f ???
	???:0
0x7f5718429349 ???
	???:0
0x561f49f2b764 ???
	../sysdeps/x86_64/start.S:115
0xffffffffffffffff ???
	???:0
topology: FATAL SIGNAL 11 (version v0.12.0)
0x561f49f56244 send_backtrace
	common/daemon.c:33
0x561f49f562ec crashdump
	common/daemon.c:46
0x7f571843e8df ???
	???:0
0x0 ???
	???:0

getinfo output

"version": "v0.12.0",
@rustyrussell rustyrussell added this to the v0.12.1 milestone Sep 14, 2022
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Sep 14, 2022
@rustyrussell
gossmap: don't crash if we see a duplicate channel_announce.
ccede9d 
Apparently we had two private channel announcements (the !private assert
failed).  While this shouldn't happen, don't crash because of it.

Fixes: ElementsProject#5578
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Plugins: topology plugin could crash when it sees duplicate private channel announcements.
@rustyrussell rustyrussell mentioned this issue Sep 14, 2022
Merged
@rustyrussell rustyrussell self-assigned this Sep 14, 2022
niftynei pushed a commit that referenced this issue Sep 14, 2022
@rustyrussell @niftynei
gossmap: don't crash if we see a duplicate channel_announce.
1121150 
Apparently we had two private channel announcements (the !private assert
failed).  While this shouldn't happen, don't crash because of it.

Fixes: #5578
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Plugins: topology plugin could crash when it sees duplicate private channel announcements.
niftynei pushed a commit that referenced this issue Sep 14, 2022
@rustyrussell @niftynei
gossmap: don't crash if we see a duplicate channel_announce.
7b506d5 
Apparently we had two private channel announcements (the !private assert
failed).  While this shouldn't happen, don't crash because of it.

Fixes: #5578
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Plugins: topology plugin could crash when it sees duplicate private channel announcements.
whitslack pushed a commit to whitslack/lightning that referenced this issue Oct 8, 2022
@rustyrussell @whitslack
gossmap: don't crash if we see a duplicate channel_announce.
b463e31 
Apparently we had two private channel announcements (the !private assert
failed).  While this shouldn't happen, don't crash because of it.

Fixes: ElementsProject#5578
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Plugins: topology plugin could crash when it sees duplicate private channel announcements.
whitslack pushed a commit to whitslack/lightning that referenced this issue Oct 28, 2022
@rustyrussell @whitslack
gossmap: don't crash if we see a duplicate channel_announce.
3df431e 
Apparently we had two private channel announcements (the !private assert
failed).  While this shouldn't happen, don't crash because of it.

Fixes: ElementsProject#5578
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Plugins: topology plugin could crash when it sees duplicate private channel announcements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
None yet
Projects
None yet
Milestone
v0.12.1
Development

Successfully merging a pull request may close this issue.

gossmap: don't crash if we see a duplicate channel_announce. rustyrussell/lightning
2 participants
@rustyrussell @heyambob