gossmap: don't crash if we see a duplicate channel_announce. #5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently we had two private channel announcements (the !private assert failed). While this shouldn't happen, don't crash because of it. Fixes: ElementsProject#5578 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Plugins: topology plugin could crash when it sees duplicate private channel announcements.
|
ACK ccede9d |
|
Leaving open for now since it needs to be cherry-picked into v0.12.1 |
endothermicdev
approved these changes
Sep 14, 2022
| @@ -414,11 +414,8 @@ static struct gossmap_chan *add_channel(struct gossmap *map, | |||
| * that's the only time we get duplicates */ | |||
| scid.u64 = map_be64(map, cannounce_off + plus_scid_off); | |||
| chan = gossmap_find_chan(map, &scid); | |||
| if (chan) { | |||
| assert(chan->private); | |||
| assert(!private); | |||
There was a problem hiding this comment.
Do we know the cause of the duplicate private channel announcement? Maybe log this case with status_broken for visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we had two private channel announcements (the !private assert failed). While this shouldn't happen, don't crash because of it.
Fixes: #5578
Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-Fixed: Plugins: topology plugin could crash when it sees duplicate private channel announcements.