pyln: Add type-annotations and a number of smaller cleanups #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
pyln
branch
2 times, most recently
from
55cf9ef
to
e2569c6
Compare
cdecker
force-pushed
the
pyln
branch
2 times, most recently
from
d5c9e85
to
99265b9
Compare
cdecker
changed the title
cdecker
requested review from
rustyrussell and
niftynei
and removed request for
rustyrussell
Several times we had issues with plugins not being able to re-encode an RPC result because they forgot to use the custom encoder class. This allows us to patch the JSONEncoder when we start the RPC or the plugin and automagically support classes that provide a `to_json` method.
This should help users that have type-checking enabled.
It is inconsistent with the RPC method, which was bothering me for some time.
|
Ack e802b12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to bootstrap typing the pyln libraries as much as possible. It also reshuffles some primitives and merges the ones where we had multiple implementations.
Changelog-None