Pure-python implementation of the Sphinx onion protocol #4056
Conversation
cdecker
force-pushed
the
pyln-onion
branch
2 times, most recently
from
1ed32a5
to
0df8243
Compare
| @@ -67,4 +69,75 @@ def __str__(self): | |||
| return "{self.block}x{self.txnum}x{self.outnum}".format(self=self) | |||
|
|
|||
| def __eq__(self, other): | |||
| return self.block == other.block and self.txnum == other.txnum and self.outnum == other.outnum | |||
| return ( | |||
There was a problem hiding this comment.
this seems like something a bit different from a type annotations update. should be in a separate commit. also seems to be missing type annotation information?
There was a problem hiding this comment.
Well it's just reformatting some code, but you're right I forgot to add the annotations here (mypy seemed to infer them correctly).
| @@ -739,7 +739,9 @@ def restart(self, timeout=10, clean=True): | |||
| self.start() | |||
|
|
|||
| def fund_channel(self, l2, amount, wait_for_active=True, announce_channel=True): | |||
There was a problem hiding this comment.
is there a way to mark this as deprecated?
There was a problem hiding this comment.
There's the warnings package which is a bit heavy handed (runtime warnings). I added a warning since this is mostly used in testing anyway.
cdecker
force-pushed
the
pyln-onion
branch
3 times, most recently
from
fd9044a
to
cac7c42
Compare
|
I moved the deprecation of |
cdecker
force-pushed
the
pyln-onion
branch
2 times, most recently
from
e3e1a71
to
a46b8df
Compare
cdecker
changed the title
|
|
||
| @classmethod | ||
| def from_hex(cls, s: str): | ||
| return cls.from_bin(unhexlify(s)) |
There was a problem hiding this comment.
we should really wean off unhexlify and hexlify in favor of bytes.fromhex() and bytes.hex()...
|
|
||
| return struct.pack("b", self.version) + \ | ||
| ephkey + \ | ||
| self.payloads + \ |
There was a problem hiding this comment.
The backslashes here are kinda weird?
Suggested-by: Rusty Russell <@rustyrussell> Signed-off-by: Christian Decker <@cdecker>
Changelog-Added: pyln-proto: Added pure python implementation of the sphinx onion creation and processing functionality.
Suggested-by: Lisa <@niftynei>
rustyrussell
force-pushed
the
pyln-onion
branch
from
898c324
to
18b6939
Compare
|
Ack 18b6939 |
rustyrussell
added
the
Optech Make Me Famous!
This is a simple (insecure) implementation of the onion creation and processing functionality. It is mainly intended to be used in
lnprototestand experimental code, but is not guaranteed to have constant-time execution, and should not be used in production.The PR builds on top of #3811, so the real content is in the last 4 commits.
Depends #3811