Address Code Review Issues #37
Open
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsella
approved these changes
Oct 2, 2024
Just out of preference, since it makes it clear we are just mapping a conversion over all the elements in the powers' list.
And hardcode to work on a 384-bit value. I'm doing this for two reasons: first, because it better matches the Python spec; second, because it will only ever be used a 384-bit value, so there is no need for it to be more abstract; and third, because it reduces complexity making the function be monomorphic.
Previously, I got the LSB by calling the custom int_to_bit function, but this can be done by indexing the zero-ith bit from the back, using '!0'.
Since it was no longer used and there is a builtin way to get the LSB.
The Python spec function multi_exp handles both G1 and G2 points. Our g1_multi_exp is hardcoded to G1 points.
Preference for readability and to imply case matching.
In the decompress_G1 function. We now match the Python spec.
b13decker
force-pushed
the
spec/fix/code-review-issues
branch
from
faf9dc9
to
d7d6bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27, closes #28, closes #31, closes #32, closes #33.