Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Code Review Issues #37

Open
wants to merge 7 commits into
base: spec/feature/bls-dependencies
Choose a base branch
from
Open

Address Code Review Issues #37

wants to merge 7 commits into from
+26 −26

Commits on Oct 3, 2024

  1. blshelpers: Replace list comprehension with map in compute_powers 

    Just out of preference, since it makes it clear we are just mapping a
conversion over all the elements in the powers' list.
    @b13decker
    b13decker committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    df3b8be View commit details
    Browse the repository at this point in the history

  2. blsserde: Remove polymorphic type n from get_flags 

    And hardcode to work on a 384-bit value. I'm doing this for two reasons:
first, because it better matches the Python spec; second, because it
will only ever be used a 384-bit value, so there is no need for it to be
more abstract; and third, because it reduces complexity making the
function be monomorphic.
    @b13decker
    b13decker committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    83ee134 View commit details
    Browse the repository at this point in the history

  3. blsserde: Replace call to int_to_bit with builtin indexing operator 

    Previously, I got the LSB by calling the custom int_to_bit function, but
this can be done by indexing the zero-ith bit from the back, using '!0'.
    @b13decker
    b13decker committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    564f347 View commit details
    Browse the repository at this point in the history

  4. utils: Remove unused function int_to_bit 

    Since it was no longer used and there is a builtin way to get the LSB.
    @b13decker
    b13decker committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    155acc6 View commit details
    Browse the repository at this point in the history

  5. blshelpers: Clarify differences between g1_multi_exp and multi_exp 

    The Python spec function multi_exp handles both G1 and G2 points. Our
g1_multi_exp is hardcoded to G1 points.
    @b13decker
    b13decker committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1fd9595 View commit details
    Browse the repository at this point in the history

  6. blsserde: Use | in place of nested if else 

    Preference for readability and to imply case matching.
    @b13decker
    b13decker committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6e2a0cf View commit details
    Browse the repository at this point in the history

  7. blsserde: Add missing check for point at infinity from compressed value 

    In the decompress_G1 function. We now match the Python spec.
    @b13decker
    b13decker committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d7d6bbe View commit details
    Browse the repository at this point in the history