-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use external hal #66
Use external hal #66
Conversation
This PR will not be merged until Drupal 10 is released. |
This replaces #65 |
suggestion to make this a 3.x branch of jsonld (because changing the supported Drupal from 9 only to 10 only would make this a major version, wouldn't it?) |
That is fine by me, probably makes sense not to rush to create a IMHO Better to wait until Drupal 10 is actually released and we are starting to make sure we (Islandora) are compliant. |
Yeah, D10's been released so we should get on this! From what I gather, the composer requirement for the external hal is needed if and only if we're on Drupal 10, but it will conflict with Drupal 9. I don't think it's possible (please correct me if i'm wrong) for there to be a branch where the Composer file is compatible with 9 or 10. I think (again, I hope y'all know more than me) that we'll need to create a jsonld:3.x branch which will be for D10 and only D10. This PR (with a few modifications) can start this off. But islandora/islandora currently has a requirement for |
php-versions: ["7.4", "8.0", "8.1"] | ||
drupal-version: ["9.3.x", "9.4.x-dev"] | ||
php-versions: ["8.0", "8.1"] | ||
drupal-version: ["10.0.x-dev", "10.1.x-dev"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"10.0" instead of "10.0.x-dev"
@@ -20,7 +20,8 @@ | |||
} | |||
], | |||
"require" : { | |||
"php": ">=7.4" | |||
"php": ">=8.0", | |||
"drupal/hal-hal": "^1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For D10, this seems it should be "drupal/hal": "^2"
at least per https://www.drupal.org/project/hal
- hal | ||
- serialization | ||
- rdf | ||
- drupal:hal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be hal:hal
etc.
Closing in favour of #69 |
GitHub Issue: #63
What does this Pull Request do?
Includes contrib module HAL dependency
What's new?
(i.e. Regeneration activity, etc.)? no
How should this be tested?
Still be able to produce JSON-LD serializations of Drupal objects.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers