Drupal 10 readiness

[rosiel]

GitHub Issue: #63 , supercedes PR #66

• Other Relevant Links (Google Groups discussion, related pull requests,
  Release pull requests, etc.)

What does this Pull Request do?

Tells Drupal the jsonld module is compatible with Drupal 10 (and also Drupal 9). This assertion still needs to be proven, hence this PR is in draft. Turned out it is impossible to be D9 and D10 compatible simultaneously, so this now proposes a 3.x branch to accommodate Drupal 10.

What's new?

• update composer.json
• update info.yml
• update testing scenarios
• (new) Update README.md.

How should this be tested?

Install the module in Drupal 10 (and in D9) and set up an RDF mapping to jsonld and expose it at an endpoint. Does it work? Any messages in the watchdog logs?

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

[rosiel]

Currently stymied by the pdf module, which doesn't have a D10 release though a patch generated by Rector is RTBC several times over, and folks are clamoring for it to get merged.

The pdf module is installed in all our workflow testing environments by islandora_ci.

[rosiel]

I've got it running on a Drupal 10 site. @whikloj I'm trying to test but not 100% sure if this is what I'm supposed to do:

I installed restUI and got this error:
Fatal error: Declaration of Drupal\jsonld\Normalizer\NormalizerBase::supportsNormalization($data, $format = null) must be compatible with Drupal\serialization\Normalizer\NormalizerBase::supportsNormalization($data, ?string $format = null, array $context = []): bool in /var/www/html/web/modules/contrib/jsonld/src/Normalizer/NormalizerBase.php on line 23

[whikloj]

@rosiel that is probably because we don't have return types defined and that (in PHP 8) means we are not correctly extending the base class.
Based on 10.1.x version of Drupal, it appears we should have a bool return type for that method.
https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/serialization/src/Normalizer/NormalizerBase.php#L26

You probably want to check the other methods we are overriding to ensure our signatures match the base class.

[rosiel]

OK, I updated three files based on running into errors, and now I can load the jsonld version of a node. CI will still fail because of pdf, though.

[rosiel]

Installing this on Drupal 9 fails:

PHP Fatal error: Declaration of Drupal\jsonld\Normalizer\NormalizerBase::supportsNormalization($data, ?string $format = null, array $context = []): bool must be compatible with Drupal\serialization\Normalizer\NormalizerBase::supportsNormalization($data, $format = null) in /var/www/html/drupal/web/modules/contrib/jsonld/src/Normalizer/NormalizerBase.php on line 23

Does this mean that because the core serializer class' signature has changed, therefore we need a new branch for D10?

[whikloj]

Yep
https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/modules/serialization/src/Normalizer/NormalizerBase.php?ref_type=heads#L34

[whikloj]

I guess this will have to be a new branch with a new major version.

[rosiel]

I've altered the target branch, changed the workflows (they'll still fail due to pdf), and added a note in the README. For linking purposes, this addresses part of Islandora/documentation#2235.

[rosiel]

Since Islandora/islandora_ci#18 was merged, I updated the tests so they don't point to my patch branch of the Islandora CI repo.

[alxp]

Works for me and PHPUnit shows no new warnings.