Skip to content

Commit

Permalink
Remove warning in juliatype (#290)
Browse files Browse the repository at this point in the history
* Remove warning in juliatype

This addresses issue #279

* Remove test for unknown types in database
  • Loading branch information
ziotom78 committed Apr 12, 2022
1 parent d99fdfb commit 96fe080
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
1 change: 0 additions & 1 deletion src/SQLite.jl
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ function juliatype(decl_typestr::AbstractString,
elseif occursin(r"^NUMERIC\(\d+,\d+\)$", typeuc)
return Float64
else
@warn "Unsupported SQLite declared type $decl_typestr, falling back to $default type"
return default
end
end
Expand Down
13 changes: 1 addition & 12 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -505,18 +505,7 @@ end
435,
],
)
rr = (;) # just to have the var declared
@test_logs(
(
:warn,
"Unsupported SQLite declared type UNKNOWN1, falling back to String type",
),
(
:warn,
"Unsupported SQLite declared type UNKNOWN2, falling back to $(Int64) type",
),
rr = DBInterface.execute(rowtable, binddb, "SELECT * FROM temp")
)
rr = DBInterface.execute(rowtable, binddb, "SELECT * FROM temp")
@test length(rr) == 1
r = first(rr)
@test typeof.(Tuple(r)) == (
Expand Down

0 comments on commit 96fe080

Please sign in to comment.