Remove warning in juliatype #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue JuliaDatabases#279
|
Thanks for the PR @ziotom78! It looks like there's a specific test looking for the warning to be printed; would you mind just removing that test? Then this should be good to merge. |
|
@quinnj , sorry! So silly of me, I forgot to check if there were tests for the warning. |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 86.01% 85.99% -0.02%
==========================================
Files 5 5
Lines 708 707 -1
==========================================
- Hits 609 608 -1
Misses 99 99
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #279