Add replace keyword arg to SQLite.load! #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #243. Allows changing the "load" generated statement from INSERT to REPLACE. We also add in error checking on each statement execution, otherwise we never see an error in the INSERT case for primary key duplication (it just silently fails and doesn't insert, which isn't great).
This was referenced Oct 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 85.14% 85.27% +0.12%
==========================================
Files 5 5
Lines 680 686 +6
==========================================
+ Hits 579 585 +6
Misses 101 101
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243. Allows changing the "load" generated statement from INSERT
to REPLACE. We also add in error checking on each statement execution,
otherwise we never see an error in the INSERT case for primary key
duplication (it just silently fails and doesn't insert, which isn't
great).