Allow selection of constraint conflict resolution algorithm in SQLite.load! #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 4 4
Lines 560 560
=======================================
Hits 530 530
Misses 30 30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
@metab0t |
quinnj
reviewed
Oct 6, 2022
src/tables.jl
Outdated
| @@ -214,14 +214,15 @@ function tableinfo(db::DB, name::AbstractString) | |||
| end | |||
|
|
|||
| """ | |||
| source |> SQLite.load!(db::SQLite.DB, tablename::String; temp::Bool=false, ifnotexists::Bool=false, replace::Bool=false, analyze::Bool=false) | |||
| SQLite.load!(source, db, tablename; temp=false, ifnotexists=false, replace::Bool=false, analyze::Bool=false) | |||
| source |> SQLite.load!(db::SQLite.DB, tablename::String; temp::Bool=false, ifnotexists::Bool=false, replace::Bool=false, or::Union{String, Nothing} = nothing, analyze::Bool=false) | |||
There was a problem hiding this comment.
What is or here? Should this be on_conflict instead?
There was a problem hiding this comment.
Ah yes, seems I forgot to update that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#263 allows the choice between INSERT or REPLACE for the load! function. However, there are several other constraint conflict resolution algorithms listed in the SQLite specification, which could also be supported.
This pull request adds another keyword argument
or::Union{String, Nothing}to the load! function, which is set tonothingby default. Valid values includenothing, "ROLLBACK", "ABORT", "FAIL", "IGNORE" and "REPLACE". For backwards compatibility, thereplacekeyword argument is left intact. If the new argument is set to its default value ofnothing, the old keyword arbitrates between INSERT and REPLACE.