Ensure that :boundscheck is properly handled
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous fix was incorrect because `:boundscheck` returns a `Bool`. Let's just force it to `true` for now, which implicitly disables `@inbounds`, which is probably a good idea for us since we haven't gone through the effort of ensuring that all indexing is still valid. Add tests for this so that we catch this breakage faster next time.
| let var"'" = Diffractor.PrimeDerivativeFwd | ||
| @test_throws BoundsError foo_errors'(1.0) == 1.0 | ||
| end |
There was a problem hiding this comment.
you might want to add a test of a function with @inbounds that has a chain rule with invalid indexing.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 52.29% 52.38% +0.08%
==========================================
Files 27 27
Lines 2719 2722 +3
==========================================
+ Hits 1422 1426 +4
+ Misses 1297 1296 -1
☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous fix was incorrect because
:boundscheckreturns aBool. Let's just force it totruefor now, which implicitly disables@inbounds, which is probably a good idea for us since we haven't gone through the effort of ensuring that all indexing is still valid. Add tests for this so that we catch this breakage faster next time.