Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that :boundscheck is properly handled #177

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Ensure that :boundscheck is properly handled #177

merged 1 commit into from
Jun 29, 2023

Commits on Jun 29, 2023

  1. Ensure that :boundscheck is properly handled 

    My previous fix was incorrect because `:boundscheck` returns a `Bool`.
Let's just force it to `true` for now, which implicitly disables
`@inbounds`, which is probably a good idea for us since we haven't gone
through the effort of ensuring that all indexing is still valid.
Add tests for this so that we catch this breakage faster next time.
    @staticfloat
    staticfloat committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    4924411 View commit details
    Browse the repository at this point in the history