Fix market name #1221
Merged
Fix market name #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
platschi
previously approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Looks good. Just left one comment about a place where we might still need to import the getMarketName function. Was also wondering if we could maybe make the getMarketName function only take in a FuturesMarketAsset, to make sure that we don't misuse it in the future. I understand that that might lead to a number of type fixes that might be beyond the scope of this PR though.
platschi
approved these changes
Aug 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
[ASSET]-PERPmarket name to the market object, and replace all instances to use the market info or util function.Description
Replace all market name instances with a version created by utility function.
Related issue