Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather module: add incremens for hourly #2996

Closed
Coernel82 opened this issue Jan 8, 2023 · 8 comments · Fixed by #2998
Closed

Weather module: add incremens for hourly #2996

Coernel82 opened this issue Jan 8, 2023 · 8 comments · Fixed by #2998
Assignees
@rejas
Labels
ready (coming with next release)

Comments

@Coernel82
Copy link

It would be very great if the default weather module would be able to show the hourly weather with for instance increments = 2 resulting in:

  • 12:00
  • 14:00
  • 16:00

increments = 3 resulting in:

  • 12:00
  • 15:00
  • 18:00

and so on...
as on smaller screens hourly clutters the screen very much.

I'd be very happy about this option!
@khassel
Copy link
Collaborator

khassel commented Jan 8, 2023

@rejas can you may take a look at this?

@rejas rejas self-assigned this Jan 8, 2023
@rejas
Copy link
Collaborator

rejas commented Jan 8, 2023

already on it, might have something soonish ;-)

@Coernel82
Copy link
Author

Wow, this would be great! I wish I could program more than I am able to at the moment!

@rejas rejas mentioned this issue Jan 8, 2023
Merged
@rejas
Copy link
Collaborator

rejas commented Jan 8, 2023

PR created if you want to check it out

@Coernel82
Copy link
Author

Cool! Is there a pull command I can use?
S.th. like git pull https://github.com/MichMich/MagicMirror/pull/2998?

@Coernel82
Copy link
Author

OK... I found something and tried git fetch origin pull/2998/head:MichMich/MagicMirror - let's see if it worked.

The new variable is: hourlyForecastIncrements: 1, by the way. Set it to 4 and will report back!

@Coernel82
Copy link
Author

The git fetch command didn't work but finally figured it out:

git fetch origin pull/2998/head:MagicMirror
git checkout MagicMirror

and: It works so far. I will keep testing for the next days.

@Coernel82
Copy link
Author

still working! Happy that this will be in the next major version in april!

khassel pushed a commit that referenced this issue Jan 10, 2023
@rejas
Add option to show hourly forecast in increments (#2998)
6e80e5a 
Adds new config option to show weather forecast for every X hour
(default value is 1 which reflects the current behaviour)
Also adds tests for hourly forecast
Fixes #2996

Co-authored-by: veeck <michael@veeck.de>
MichMich added a commit that referenced this issue Apr 4, 2023
@MichMich
Release 2.23.0 (#3078)
abe5c08 
## [2.23.0] - 2023-04-04

Thanks to: @angeldeejay, @buxxi, @CarJem, @dariom, @DaveChild, @dWoolridge, @grenagit, @Hirschberger, @KristjanESPERANTO, @MagMar94, @naveensrinivasan, @nfogal, @psieg, @rajniszp, @retroflex, @SkySails and @tomzt.

Special thanks to @khassel, @rejas and @sdetweil for taking over most (if not all) of the work on this release as project collaborators. This version would not be there without their effort. Thank you guys! You are awesome!

### Added

- Added increments for hourly forecasts in weather module (#2996)
- Added tests for hourly weather forecast
- Added possibility to ignore MagicMirror repo in updatenotification module
- Added Pirate Weather as new weather provider (#3005)
- Added possibility to use your own templates in Alert module
- Added error message if `<modulename>.js` file is missing in module folder to get a hint in the logs (#2403)
- Added possibility to use environment variables in `config.js` (#1756)
- Added option `pastDaysCount` to default calendar module to control of how many days past events should be displayed
- Added thai language to alert module
- Added option `sendNotifications` in clock module (#3056)

### Removed

- Removed darksky weather provider
- Removed unneeded (and unwanted) '.' after the year in calendar repeatingCountTitle (#2896)

### Updated

- Use develop as target branch for dependabot
- Update issue template, contributing doc and sample config
- The weather modules clearly separates precipitation amount and probability (risk of rain/snow)
  - This requires all providers that only supports probability to change the config from `showPrecipitationAmount` to `showPrecipitationProbability`.
- Update tests for weather and calendar module
- Changed updatenotification module for MagicMirror repo only: Send only notifications for `master` if there is a tag on a newer commit
- Update dates in Calendar widgets every minute
- Cleanup jest coverage for patches
- Update `stylelint` dependencies, switch to `stylelint-config-standard` and handle `stylelint` issues, update `main.css` matching new rules
- Update Eslint config, add new rule and handle issue
- Convert lots of callbacks to async/await
- Revise require imports (#3071 and #3072)

### Fixed

- Fix wrong day labels in envcanada forecast (#2987)
- Fix for missing default class name prefix for customEvents in calendar
- Fix electron flashing white screen on startup (#1919)
- Fix weathergov provider hourly forecast (#3008)
- Fix message display with HTML code into alert module (#2828)
- Fix typo in french translation
- Yr wind direction is no longer inverted
- Fix async node_helper stopping electron start (#2487)
- The wind direction arrow now points in the direction the wind is flowing, not into the wind (#3019)
- Fix precipitation css styles and rounding value
- Fix wrong vertical alignment of calendar title column when wrapEvents is true (#3053)
- Fix empty news feed stopping the reload forever
- Fix e2e tests (failed after async changes) by running calendar and newsfeed tests last
- Lint: Use template literals instead of string concatenation
- Fix default alert module to render HTML for title and message
- Fix Open-Meteo wind speed units
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rejas rejas

Labels
ready (coming with next release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to show hourly forecast in increments rejas/MagicMirror
3 participants
@rejas @Coernel82 @khassel