Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show hourly forecast in increments #2998

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Jan 8, 2023

Adds new config option to show weather forecast for every X hour (default value is 1 which reflects the current behaviour)
Also adds tests for hourly forecast
Fixes #2996

@rejas rejas changed the base branch from master to develop January 8, 2023 21:37
@codecov-commenter
Copy link

Codecov Report

Merging #2998 (7fc6ada) into develop (7bc91a7) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2998      +/-   ##
===========================================
+ Coverage    21.95%   22.02%   +0.06%     
===========================================
  Files           51       51              
  Lines        11292    11297       +5     
===========================================
+ Hits          2479     2488       +9     
+ Misses        8813     8809       -4     
Impacted Files Coverage Δ
modules/default/weather/weather.js 0.00% <0.00%> (ø)
modules/default/updatenotification/node_helper.js 80.00% <0.00%> (+12.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@khassel khassel merged commit 6e80e5a into MagicMirrorOrg:develop Jan 10, 2023
@rejas rejas deleted the feature/issue-2996 branch January 10, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weather module: add incremens for hourly
3 participants