Product serialization: fixed snake_case and camelCase serialization inconsistency #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nconsistency Pointed out by RevenueCat/react-native-purchases#388 Using the major release in all the hybrids to fix this.
NachoSoto
added
enhancement
This was referenced Aug 2, 2022
Merged
NachoSoto
added a commit
that referenced
this pull request
Aug 2, 2022
- Fixed snake_case and camelCase serialization inconsistency in `StoreProduct` (#187) - Updated `purchases-ios` to [4.9.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.9.1)
NachoSoto
added a commit
to RevenueCat/react-native-purchases
that referenced
this pull request
Aug 5, 2022
Fixes #388. As far as I know this was just a mistake in version 4.x, so the 5.0 major bump is a good opportunity to fix this. Depends on RevenueCat/purchases-hybrid-common#187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by RevenueCat/react-native-purchases#388
Using the major release in all the hybrids to fix this.