Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename remaining snake_case items to camelCase #164

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Rename remaining snake_case items to camelCase #164

merged 2 commits into from
Aug 2, 2022

Conversation

taquitos
Copy link
Contributor

@taquitos taquitos commented Aug 2, 2022

Also bump PHC

On hold until PHC 4.0.0 drops ✋ 🎤

@NachoSoto
Copy link
Contributor

See RevenueCat/purchases-hybrid-common#187

@taquitos taquitos marked this pull request as ready for review August 2, 2022 19:52
@taquitos taquitos requested a review from a team August 2, 2022 19:52
@@ -386,15 +386,15 @@ export interface PurchasesStoreProduct {
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to delete these compiled files here too (see RevenueCat/react-native-purchases#362)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed [CSDK-369]

@taquitos taquitos merged commit f10bb5d into main Aug 2, 2022
@taquitos taquitos deleted the snek_case branch August 2, 2022 21:12
@vegaro vegaro mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants